Make xargs-r() macOS compatible #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 Thanks for opening this pull request! You're awesome. |
|
@standard/team Can someone familiar with this please give this a review? |
ungoldman
approved these changes
Nov 11, 2020
|
🎉 Congrats on getting your first pull request landed! |
|
Thank you @ungoldman for the review and @om4csaba for the PR! ❤️ |
This was referenced Mar 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[ ] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
The
pre-commitexample code of in the README fails on macOS when a file deleted in a commit. This change should solve the issue and maintain compatibility with other systems.Which issue (if any) does this pull request address?
Is there anything you'd like reviewers to focus on?
Tested only Ubuntu and macOS, should work other systems as well