Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add anti-trojan charset detection #1742

Open
simone-sanfratello opened this issue Nov 11, 2021 · 7 comments
Open

add anti-trojan charset detection #1742

simone-sanfratello opened this issue Nov 11, 2021 · 7 comments

Comments

@simone-sanfratello
Copy link

What version of this package are you using?

usually the latest

What problem do you want to solve?

https://certitude.consulting/blog/en/invisible-backdoor/

What do you think is the correct solution to this problem?

use this plugin https://github.com/lirantal/eslint-plugin-anti-trojan-source

Are you willing to submit a pull request to implement this change?

yes

@LinusU
Copy link
Member

LinusU commented Nov 11, 2021

Seems like this might be added directly to ESLint: eslint/eslint#15240

@dougwilson
Copy link

dougwilson commented Nov 11, 2021

Just as a note, the plugin linked doesn't actually detect the attack the article you linked explains; it seems the plugin is only for the bidi detection, not the invisible/homoglpyh ones the article is about. It seems the built-in eslint rule proposal @LinusU pointed to would cover all the cases unlike the plugin.

@voxpelli
Copy link
Member

Let's wait for the core one then, and keep this one open to track it 👍

@lmammino
Copy link

It seems still open on the main repo... After almost a year, should we reconsider adding it directly to Standard?

@LinusU
Copy link
Member

LinusU commented Oct 26, 2022

I pinged in the eslint issue, let's see if there is an update...

@LinusU
Copy link
Member

LinusU commented Oct 31, 2022

Upstream has requested that we file a feature request here:

https://github.com/nodesecurity/eslint-plugin-security

@simone-sanfratello or @lmammino, would you be able to do this?

@simone-sanfratello
Copy link
Author

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

5 participants