Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @jsx pragma #71

Closed
brandonhorst opened this issue Mar 18, 2015 · 3 comments
Closed

Support @jsx pragma #71

brandonhorst opened this issue Mar 18, 2015 · 3 comments

Comments

@brandonhorst
Copy link
Contributor

It's awesome that standard supports jsx now.

In addition to supporting React, babel supports generic JSX transforms, using a pragma like this:

/** @jsx mypackage.doSomething */

demo

Of course, when using them, standard is peppered with 'React' must be in scope when using JSX. Would it be possible to respect this pragma. It's not a Babel invention, React itself required it until recently.

@feross
Copy link
Member

feross commented Mar 18, 2015

standard just uses eslint-plugin-react to support jsx. We could just disable the "react-in-jsx-scope" rule - but it seems useful for most users.

I would suggest opening an issue on eslint-plugin-react and ask them to support the @jsx pragma.

@brandonhorst
Copy link
Contributor Author

Will do, thanks.

@feross
Copy link
Member

feross commented Mar 19, 2015

Yep :)

@feross feross reopened this Mar 19, 2015
@feross feross closed this as completed Mar 19, 2015
@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants