Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White space between tiles when cropping #16

Closed
wouteeckhout opened this issue Aug 6, 2014 · 4 comments
Closed

White space between tiles when cropping #16

wouteeckhout opened this issue Aug 6, 2014 · 4 comments

Comments

@wouteeckhout
Copy link

cropwhiteline

I'm having white spaces between the overlay-tiles when i'm cropping large .PNG files. I'm using Chrome 35.0.1916.153 and do not have my browser zoomed in.

Any ideas how to solve this?

@wouteeckhout
Copy link
Author

This can be solved with calling following functions in moveBorders and moveCropzone:

var ceilOffHWZones, ceilOffXYZones;
ceilOffHWZones = function() {
scope.heightCropZone = Math.ceil(scope.heightCropZone);
return scope.widthCropZone = Math.ceil(scope.widthCropZone);
};
ceilOffXYZones = function() {
scope.xCropZone = Math.ceil(scope.xCropZone);
return scope.yCropZone = Math.ceil(scope.yCropZone);
};

Might push / pull request this when I have time.

@standuprey
Copy link
Owner

Awesome, I would appreciate a pull request to solve this

@standuprey
Copy link
Owner

I can't reproduce this. Can you provide the picture?

@wouteeckhout
Copy link
Author

Here's the picture: http://i.imgur.com/7EPHD.png
Can't really do a pull request because I converted your project to coffeescript and it's already integrated with new features etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants