Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if (largestFeasible > 0) check is useless #4

Closed
errx opened this issue Sep 6, 2017 · 1 comment
Closed

if (largestFeasible > 0) check is useless #4

errx opened this issue Sep 6, 2017 · 1 comment

Comments

@errx
Copy link

errx commented Sep 6, 2017

ASAP/ASAP-optimized.js

Line 248 in 24e95b2

var largestFeasible = -1;

ASAP/ASAP-optimized.js

Line 267 in 24e95b2

if (largestFeasible > 0) {

or there is a bug?
@kexinrong
Copy link
Contributor

Thanks for pointing this out! It was a bug in the implementation, but it shouldn't really affect the results since the parameter was mostly for optimization.

I pushed a fix to the javascript and the python implementation. Please let me know if you have questions.

@errx errx closed this as completed Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@errx @kexinrong