Port almond-server to TypeScript #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for adding support for TypeScript, which will require a build step, move all sources to a subdirectory, so relative paths to assets and data files remain the same from the source or build directory.
And convert the main entrypoint to typescript
As required by TypeScript
Suprisingly painless. The biggest change is avoiding "app.engine" because "engine" is already a method in express. This is a preexisting bug that happened to work by chance, and TypeScript caught.
With this, all server side code is now TypeScript!
We updated genie-toolkit to master, so we need to update the tests a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A complete port, suprisingly quick.