Auto-spawn a genie-client on startup #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it more similar to the build of the Home Assistant add-on, and bring in the genie-client in the container
gcampax
force-pushed
the
wip/genie-client
branch
from
44a450d
to
ce06359
Compare
|
With this PR, I have a working standalone docker that has sound, using the new client. The build is almost identical to the add-on so porting to Home Assistant should be straightforward. |
Optional dependencies don't work with TypeScript, and the library should build just fine on Mac OS with PulseAudio from Homebrew (as well as Linux of course). On Windows, use the docker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the basic change to get a genie-client to run in the container.
For the separate speaker use case, I think we'll expose the access token in the configuration page, and add the ability to create ingress session tokens using the supervisor API to communicate through the add-on ingress.