Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatasetSplitter should not put equivalent sentences in the evaluation sets #9

Closed
gcampax opened this issue Feb 25, 2019 · 1 comment
Closed

DatasetSplitter should not put equivalent sentences in the evaluation sets #9

gcampax opened this issue Feb 25, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@gcampax
Copy link
Contributor

gcampax commented Feb 25, 2019

If two sentences are different only in unquoted parameters, they should not appear twice in the evaluation (dev/test) sets - that is, the dev/test sets should undo parameter expansion.
I've made this mistake multiple times before, and I've made it in the latest code to... 😭
@gcampax gcampax added the bug Something isn't working label Feb 25, 2019
@gcampax
Copy link
Contributor Author

gcampax commented Apr 5, 2019

This was fixed by #28

@gcampax gcampax closed this as completed Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gcampax