Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in bing skill #430

Closed
gcampax opened this issue Sep 5, 2021 · 1 comment
Closed

Error in bing skill #430

gcampax opened this issue Sep 5, 2021 · 1 comment
Assignees
@gcampax
Labels
bug P1 We're working on it right now ready-for-qa Ready for testing by original reporter release: main Issues that affect devices in the "main" release

Comments

@gcampax
Copy link
Contributor

gcampax commented Sep 5, 2021

From the scenario tests:

TypeError: bestRankingItems.push is not iterable (cannot read property Symbol(Symbol.iterator))
    at BingDialogueHandler.analyzeCommand (/home/travis/build/stanford-oval/thingpedia-common-devices/main/com.bing/index.js:48:676)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async ThingpediaDialogueHandler.analyzeCommand (/home/travis/build/stanford-oval/thingpedia-common-devices/node_modules/genie-toolkit/dist/lib/dialogue-agent/handlers/3rdparty.js:109:23)
    at async DialogueLoop._analyzeCommand (/home/travis/build/stanford-oval/thingpedia-common-devices/node_modules/genie-toolkit/dist/lib/dialogue-agent/dialogue-loop.js:173:34)
    at async DialogueLoop._handleUserInput (/home/travis/build/stanford-oval/thingpedia-common-devices/node_modules/genie-toolkit/dist/lib/dialogue-agent/dialogue-loop.js:291:41)
    at async DialogueLoop._loop (/home/travis/build/stanford-oval/thingpedia-common-devices/node_modules/genie-toolkit/dist/lib/dialogue-agent/dialogue-loop.js:354:21)
Invalid reply: Sorry, I had an error processing your command: bestRankingItems.push is not iterable (cannot read property Symbol(Symbol.iterator)).
>> expecting = null
@gcampax gcampax added bug release: main Issues that affect devices in the "main" release P1 We're working on it right now labels Sep 5, 2021
@jmhw0123 jmhw0123 mentioned this issue Sep 8, 2021
Merged
@gcampax gcampax assigned gcampax and unassigned jmhw0123 Sep 8, 2021
@gcampax gcampax added the ready-for-qa Ready for testing by original reporter label Sep 8, 2021
@gcampax
Copy link
Contributor Author

gcampax commented Sep 12, 2021

Scenario tests have been happy for a while, I think this was fixed.

@gcampax gcampax closed this as completed Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gcampax gcampax

Labels
bug P1 We're working on it right now ready-for-qa Ready for testing by original reporter release: main Issues that affect devices in the "main" release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gcampax @jmhw0123