Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sas_counters: Fix exception when bay_identifier returns EINVAL #7

Closed
ghost opened this issue Aug 8, 2017 · 0 comments
Closed

sas_counters: Fix exception when bay_identifier returns EINVAL #7

ghost opened this issue Aug 8, 2017 · 0 comments

Comments

@ghost
Copy link

ghost commented Aug 8, 2017

Any attempt to read the bay_identifier sysfs file returns EINVAL for some sas_end_devices, it seems. In this case, sas_counters.py errors out with the following traceback because unlike other parts of the code base that touch the bay_identifier attribute, ValueError isn't caught here so far:

(...)
  File "/usr/lib/python2.7/site-packages/sasutils/cli/sas_counters.py", line 101, in portsortfunc
    sortv[2] = int(port_n.end_devices[0].sas_device.attrs
ValueError: invalid literal for int() with base 10: '[Errno 22] Invalid argument'
@thiell thiell closed this as completed in 95e6bb0 Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants