Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move genesis2 installation from CGRAGenerator/bin/generate.csh to setup.sh #38

Closed
leonardt opened this issue Dec 15, 2017 · 4 comments
Closed
Assignees

Comments

@leonardt
Copy link
Contributor

leonardt commented Dec 15, 2017

Ideally we have all setup logic outside of the makefile, currently the call to generate.csh will result in a git clone for genesis2 if it's not present.

@steveri
Copy link
Contributor

steveri commented Dec 16, 2017

Sure no problem, I will create a 'genesis2' branch and pull request...

@steveri
Copy link
Contributor

steveri commented Dec 16, 2017

Hmmm, tricky, since you have an open pull request; maybe I will wait for that to close before I do this.
And/or if you want to include it in the pull request, it's just a simple matter of adding this to install.sh:

git clone https://github.com/StanfordVLSI/Genesis2.git/tmp/Genesis2

As you probably know, this then short-circuits the later git clone...

@steveri
Copy link
Contributor

steveri commented Dec 19, 2017

Okay I made the change, it's building now...after it passes I will close out this issue...

@steveri
Copy link
Contributor

steveri commented Dec 19, 2017

Looks like it passed! I'm going to close us out.

https://travis-ci.org/StanfordAHA/CGRAFlow/builds/318777191

@steveri steveri closed this as completed Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants