New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Logging with named logger #24
Comments
Sure, that's fine by me. I'm currently a bit busy with other projects, but I'd welcome a PR with this change. |
I opened a PR with the changes but the test cases don't work. To me it seems unrelated to the logging functionality though. It seems that Gettr changed something on their side. E.g. the 'infl' value on the Support Profile. |
Yep, you're right. I'll take a look at the tests then we can rebase. |
tests are working fine now, thanks! |
Thanks! Merged. |
firstly: thanks for providing this nice API!
I would like to use it in a small project but the INFO logs are spamming quite much.
Could you use a named logger instead of the root logger? For example by setting the logger in the api module like:
logger = logging.getLogger(__name__)
and consecutively using logger.INFO("awesome log") instead of logging.INFO(...)
This would enable users of your library to override the log level by using:
logging.getLogger("gogettr").setLevel(logging.WARNING)
The text was updated successfully, but these errors were encountered: