Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to get comments from a post #6

Merged
merged 16 commits into from Jul 9, 2021
Merged

Add ability to get comments from a post #6

merged 16 commits into from Jul 9, 2021

Conversation

KonradIT
Copy link
Contributor

@KonradIT KonradIT commented Jul 9, 2021

  • uses /u/post/%s/comments URI for fetching comments from a specific post id.
  • uses get_paginated function to fetch comments.

More testing needs to be done on more situations (eg: 0 comments), as well as write a python test.

@milesmcc
Copy link
Collaborator

milesmcc commented Jul 9, 2021

Looks like the currently failing test is due to a GETTR API change. I'll take a look at that shortly and fix upstream.

@milesmcc
Copy link
Collaborator

milesmcc commented Jul 9, 2021

Alright, the test is fixed upstream, so I'll just rebase on that and you should be good to go. I'll do a quick code review pass now — everything looks good, just want to do a few small stylistic things to keep things consistent with the rest of the codebase.

@milesmcc milesmcc self-requested a review July 9, 2021 17:58
Copy link
Collaborator

@milesmcc milesmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for implementing this! Just a few small changes to keep style consistent, and then we'll be good to go!

See also the note about tests. If they're too much of a pain to add, that's alright — happy to implement them myself.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
gogettr/cli.py Outdated Show resolved Hide resolved
tests/test_comments_from_post.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
gogettr/capabilities/comments.py Outdated Show resolved Hide resolved
gogettr/capabilities/comments.py Outdated Show resolved Hide resolved
@milesmcc milesmcc merged commit 51c65d3 into stanfordio:main Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants