New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to get comments from a post #6
Conversation
Looks like the currently failing test is due to a GETTR API change. I'll take a look at that shortly and fix upstream. |
Alright, the test is fixed upstream, so I'll just rebase on that and you should be good to go. I'll do a quick code review pass now — everything looks good, just want to do a few small stylistic things to keep things consistent with the rest of the codebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for implementing this! Just a few small changes to keep style consistent, and then we'll be good to go!
See also the note about tests. If they're too much of a pain to add, that's alright — happy to implement them myself.
Co-authored-by: R. Miles McCain <github@sendmiles.email>
Co-authored-by: R. Miles McCain <github@sendmiles.email>
Co-authored-by: R. Miles McCain <github@sendmiles.email>
Co-authored-by: R. Miles McCain <github@sendmiles.email>
/u/post/%s/comments
URI for fetching comments from a specificpost id
.get_paginated
function to fetch comments.More testing needs to be done on more situations (eg: 0 comments), as well as write a python test.