Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLE/RTM instructions need to be marked as invalid #229

Closed
bchurchill opened this issue Apr 29, 2016 · 5 comments
Closed

HLE/RTM instructions need to be marked as invalid #229

bchurchill opened this issue Apr 29, 2016 · 5 comments
Assignees
@bchurchill
Labels
bug invalid

Comments

@bchurchill
Copy link
Member

I'm pretty sure we can't handle any of these, so we should turn off x64asm support for these.
@bchurchill bchurchill self-assigned this Apr 29, 2016
@bchurchill bchurchill added the bug label Apr 29, 2016
@stefanheule
Copy link
Member

What exactly is "x64asm support"? Wouldn't we mark them as unsupported in the sandbox?

@bchurchill
Copy link
Member Author

There's a column in the spreadsheet that basically means "actually, we should never assemble this".

@bchurchill
Copy link
Member Author

That entry prevents the instruction from being compiled into x64asm at all.

@stefanheule
Copy link
Member

Ah, ok. Either is fine with me.

@bchurchill
Copy link
Member Author

I'm realizing that there's really no need to do this given the other fix to STOKE to use only whitelisted CpuFlags. I guess these instructions might be useful to someone, someday, so I'll leave them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bchurchill bchurchill

Labels
bug invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bchurchill @stefanheule