Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux_caller_save() doesn't match ABI #33

Closed
bchurchill opened this issue Oct 3, 2014 · 1 comment
Closed

linux_caller_save() doesn't match ABI #33

bchurchill opened this issue Oct 3, 2014 · 1 comment
Labels

Comments

@bchurchill
Copy link
Member

I don't want to break anything, so I won't change this function quite yet. The name of these function doesn't quite match up to what they are though: linux_caller_save() currently returns the list of all registers used as parameters; however, the caller must also save rax, r9, r10 and r11, which aren't parameters.

I also have a really hard time with the names callee/caller save, but that's probably just me, so my current solution is to define four new additional functions:
linux_call_parameters()
linux_call_scratch()
linux_call_preserved()
linux_call_return() (including rax, rdx, xmm0, xmm1)

that return the appropriate sets of registers.

@bchurchill bchurchill added the bug label Oct 3, 2014
@bchurchill
Copy link
Member Author

Merged into develop only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant