Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to get the set of read/written registers to Code class #36

Closed
bchurchill opened this issue Oct 7, 2014 · 4 comments
Closed

Comments

@bchurchill
Copy link
Member

For my work I needed to get the set of possibly read and possibly written registers from a Code class. For the moment, it's implemented in my stoke branch, but it's somewhat out of place. Do you think it would make sense to add such functions here?

They're truly short functions, just 5/6 lines each.

@eschkufz
Copy link
Contributor

eschkufz commented Oct 9, 2014

Probably makes sense to add these to x64asm. It seems like a natural place
and a natural thing to want to do.

On Tue, Oct 7, 2014 at 4:27 AM, Berkeley Churchill <notifications@github.com

wrote:

For my work I needed to get the set of possibly read and possibly written
registers from a Code class. For the moment, it's implemented in my stoke
branch, but it's somewhat out of place. Do you think it would make sense to
add such functions here?

They're truly short functions, just 5/6 lines each.


Reply to this email directly or view it on GitHub
#36.

@eschkufz
Copy link
Contributor

eschkufz commented Oct 9, 2014

To the Code apit, I mean.

On Wed, Oct 8, 2014 at 8:23 PM, eric schkufza eric.schkufza@gmail.com
wrote:

Probably makes sense to add these to x64asm. It seems like a natural place
and a natural thing to want to do.

On Tue, Oct 7, 2014 at 4:27 AM, Berkeley Churchill <
notifications@github.com> wrote:

For my work I needed to get the set of possibly read and possibly written
registers from a Code class. For the moment, it's implemented in my stoke
branch, but it's somewhat out of place. Do you think it would make sense to
add such functions here?

They're truly short functions, just 5/6 lines each.


Reply to this email directly or view it on GitHub
#36.

@eschkufz
Copy link
Contributor

I'll do this now.

@eschkufz eschkufz self-assigned this Oct 14, 2014
@eschkufz
Copy link
Contributor

Done. Merge with develop.

I think stoke is checking out develop, so you should be able to see this with a make dist_clean make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants