Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when building in production #76

Closed
gamersi opened this issue Nov 16, 2022 · 8 comments
Closed

Error when building in production #76

gamersi opened this issue Nov 16, 2022 · 8 comments
Assignees

Comments

@gamersi
Copy link
Collaborator

gamersi commented Nov 16, 2022

I ran yarn build:all and when I run the output (muffon.app) this error appears:
I already tried reinstalling the node_modules

image

@staniel359 staniel359 self-assigned this Nov 16, 2022
@staniel359
Copy link
Owner

@gamersi Hello.
You need .env file in the project's root.
There are two variables, but I can't write them here.
I can send them to you.

@gamersi
Copy link
Collaborator Author

gamersi commented Nov 16, 2022

I just found that very weird because I followed the instruction from your readme. As a javascript developer myself I debugged it and thought that it would be sth like this. but could you explain why those are needed, just out of curiosity? I saw you added that a few weeks ago

@staniel359
Copy link
Owner

@gamersi Sorry, I totally forgot about build instructions.
They were written for Arch Linux users.
And as long as new version will include AppImage file, I was planning to remove the instructions.

There are actually 2 variables:

  • Local store encryption key

This one was added to protect downloaded audio files from being decrypted.
And in general, I wanted to protect local storage file from being edited and potentially break something in the app.

  • Anonymous access token

This one is a part of new API, which requires access token for all requests.

@gamersi
Copy link
Collaborator Author

gamersi commented Nov 16, 2022

Ok thank you for the quick and detailed answer.
I just wanted to build it in prod to test my language pack but now it is finished anyways.
Your Readme seems outdated in general.
When will there be a new release, considering ( as far as I saw it) the changes since the last 0.3.0 are kind of big?

@staniel359
Copy link
Owner

@gamersi

I just wanted to build it in prod to test my language pack

If you want to test it, I can send you .env file by mail.

Your Readme seems outdated in general.

Could you give me an example?

When will there be a new release

There're some difficulties with Italian translation right now.
When it is updated, the new version will be released.

@gamersi
Copy link
Collaborator Author

gamersi commented Nov 16, 2022

Could you give me an example?

The build thing is still in there
There are more translations than those who are on there
Some things that are already implemented are listed as upcoming.
or could just be me being confused right now...

There're some difficulties with Italian translation right now.
When it is updated, the new version will be released.

ok thanks

@staniel359
Copy link
Owner

@gamersi

The build thing is still in there

I'll remove it with next release.

There are more translations than those who are on there
Some things that are already implemented are listed as upcoming.
or could just be me being confused right now...

That's because you've cloned the version with yet unreleased features.
Whan new version will be released, README will be updated.

@gamersi
Copy link
Collaborator Author

gamersi commented Nov 16, 2022

OK, Thank you

@gamersi gamersi closed this as completed Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants