Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching to commonjs instead of es2015 #33

Closed
louiscloutierdakis opened this issue Sep 26, 2019 · 2 comments
Closed

Switching to commonjs instead of es2015 #33

louiscloutierdakis opened this issue Sep 26, 2019 · 2 comments

Comments

@louiscloutierdakis
Copy link

A lot of big libraries in react written in typescript are using module commonjs for a better compatibility. You can see here material-ui https://github.com/mui-org/material-ui/blob/master/tsconfig.json#L3

Could you consider switching to commonjs in compilerOptions module?
@Stanko
Copy link
Owner

Stanko commented Sep 26, 2019

I will take a look, thank you!

@Stanko
Copy link
Owner

Stanko commented Sep 26, 2019

Fixed in v2.0.2 2d3854f
🎉

@Stanko Stanko closed this as completed Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stanko @louiscloutierdakis