Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can you remove comment script tag #38

Closed
fenghuixue opened this issue Oct 24, 2019 · 4 comments
Closed

can you remove comment script tag #38

fenghuixue opened this issue Oct 24, 2019 · 4 comments

Comments

@fenghuixue
Copy link

comment script tag cause some problem when i use in iframe in development mode, can you remove it?
in 352, thank you.

<script src="https://unpkg.com/es6-promise/dist/es6-promise.auto.min.js"></script>
@Stanko
Copy link
Owner

Stanko commented Oct 24, 2019

Hello @fenghuixue,
Not sure what are you talking about? Is es6-promise creating a problem for you? Please specify the exact thing that is the problem and how to replicate it, so I can test it. I'm on vacation at the moment, so it will probably take me couple of days.

Cheers!

@fenghuixue
Copy link
Author

fenghuixue commented Oct 28, 2019

Hello @fenghuixue,
Not sure what are you talking about? Is es6-promise creating a problem for you? Please specify the exact thing that is the problem and how to replicate it, so I can test it. I'm on vacation at the moment, so it will probably take me couple of days.

Cheers!
just this line. Have fun,there's no hurry
image

@Stanko
Copy link
Owner

Stanko commented Oct 28, 2019

I honestly don't understand how does that line can make a problem, it is a comment and ignored by interpreters.

@fenghuixue
Copy link
Author

I honestly don't understand how does that line can make a problem, it is a comment and ignored by interpreters.

It's because my script inject at wrong way, thank you. I fixed it

@Stanko Stanko closed this as completed Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants