Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile Error on node 14 #50

Closed
seth-church opened this issue Oct 26, 2020 · 3 comments
Closed

Compile Error on node 14 #50

seth-church opened this issue Oct 26, 2020 · 3 comments

Comments

@seth-church
Copy link

seth-church commented Oct 26, 2020

When building version 2.0.11 using node 14 and TypeScript 3.8.3, this error results:

ERROR in node_modules/animated-scroll-to/lib/animated-scroll-to.d.ts:1:33 - error TS1005: ',' expected.

1 export declare type TCoords = [x: number | null | undefined, y: number | null | undefined];
                                  ~
node_modules/animated-scroll-to/lib/animated-scroll-to.d.ts:1:63 - error TS1005: ',' expected.

1 export declare type TCoords = [x: number | null | undefined, y: number | null | undefined];
@Stanko
Copy link
Owner

Stanko commented Oct 27, 2020

Hey,
It seems that named tuple is not supported, I'll check if I can make it backwards compatible. If not, I'll just remove named tuple.

Cheers!

EDIT: For now, use 2.0.10 until I publish a new version, sorry for the inconvenience!

@Stanko
Copy link
Owner

Stanko commented Oct 27, 2020

I reverted in 2.0.12

I have to look into keeping things like this backwards compatible.

@Stanko Stanko closed this as completed Oct 27, 2020
@seth-church
Copy link
Author

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants