Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: upgrade environment to star-spack@0.3.0 (#588)" #592

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

plexoos
Copy link
Member

@plexoos plexoos commented Sep 29, 2023

This reverts commit 3714f3d.

Not yet ready for prime time

Copy link
Contributor

@genevb genevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure there's really anything for me to review here. The default config did not point to these new files, so the new files were probably not used by anyone other than perhaps @plexoos since their merger yesterday AFAIK.

-Gene

@plexoos
Copy link
Member Author

plexoos commented Sep 29, 2023

There are errors in ROOT6 tests like this one:

In file included from Table_Cint dictionary payload:21:
LoadTable: .L /star-sw/StarDb/Geometry/tpc/tpcPadConfig.y2019.C
In file included from /star-sw/.sl79_gcc485/include/TGenericTable.h:8:
/star-sw/.sl79_gcc485/include/TTableDescriptor.h:25:33: error: base class has incomplete type
class TTableDescriptor : public TTable {
                         ~~~~~~~^~~~~~
/star-sw/.sl79_gcc485/include/TTable.h:48:7: note: definition of 'TTable' is not complete until the closing '}'
class TTable : public TDataSet {
      ^

It is likely because I removed the TTable from ROOT6.16 and the external star-table (https://github.com/star-bnl/star-table) from the environment hoping that StRoot/Table would provide the needed functionality. Clearly, it does not. Who is maintaining StRoot/Table?

@plexoos plexoos merged commit 97d7d79 into star-bnl:main Oct 2, 2023
197 checks passed
@plexoos plexoos deleted the revert_container_env branch October 2, 2023 19:26
dkapukchyan pushed a commit to dkapukchyan/star-sw that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants