Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation email about authentication using tokens #68

Closed
TheThirdOne opened this issue Feb 4, 2020 · 5 comments
Closed

Deprecation email about authentication using tokens #68

TheThirdOne opened this issue Feb 4, 2020 · 5 comments

Comments

@TheThirdOne
Copy link

Today I got an email containing the following (and information that shows it was sent because of a star-history and my token I have it linked with):

Hi @TheThirdOne,

Your personal access token was used as part of a query parameter to access an endpoint through the GitHub API

Please use the Authorization HTTP header instead, as using the access_token query parameter is deprecated.

Depending on your API usage, we'll be sending you this email reminder once every 3 days for each token and User-Agent used in API calls made on your behalf.
Just one URL that was accessed with a token and User-Agent combination will be listed in the email reminder, not all.

Visit https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters for more information.

Thanks,
The GitHub Team

It seems like this should be an easy fix; the affected lines seem to be: https://github.com/timqian/star-history/blob/7d1bbd8c950a70e97f598b981b13c1d6d5e92885/core/getStarHistory.js#L16-L23

@timqian timqian closed this as completed in 46dff95 Feb 5, 2020
@timqian
Copy link
Member

timqian commented Feb 5, 2020

@TheThirdOne Thanks for pointing it out, this issue should have been fixed for the website, the extension will be updated soon

@TheThirdOne
Copy link
Author

Thanks. It seems another email won't come again so it the fix must be working.

@timqian
Copy link
Member

timqian commented Feb 11, 2020

Reopening this issue as I met some problems publishing the new extension. Resubmitting the extension, not sure how long it will take, I will close this issue when the extension is published

@timqian timqian reopened this Feb 11, 2020
@lpil
Copy link

lpil commented Feb 13, 2020

Can you also update https://old-star-history.t9t.io/ please as it has features the new version does not yet have. Thanks

@tianzhou
Copy link
Contributor

tianzhou commented Dec 1, 2021

Version with the fix have been published

@tianzhou tianzhou closed this as completed Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants