Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy is not in the requirements of setup.py #71

Closed
qjuppet opened this issue Jul 13, 2020 · 1 comment
Closed

Numpy is not in the requirements of setup.py #71

qjuppet opened this issue Jul 13, 2020 · 1 comment

Comments

@qjuppet
Copy link

qjuppet commented Jul 13, 2020

Hello,

I'm currently working to create an environment with Renku to train StarDist models and I had an issue regarding numpy that is not installed by default and is then installed at the same time as StarDist as both are in my requirements. As StarDist need numpy, its installation failed as numpy is not yet available. I fix my issue by installing numpy before my other requirements however I suggest to add numpy in the requirements of StarDist, I think it is missing.

@uschmidt83
Copy link
Member

Hi, thanks for using StarDist.

As StarDist need numpy, its installation failed as numpy is not yet available.

Yes, thanks for reminding me about that. Since numpy is typically installed, most people don't notice.

I fix my issue by installing numpy before my other requirements

Yes, that's currently the only way.

however I suggest to add numpy in the requirements of StarDist, I think it is missing.

It's not that simple. Actually, we implicitly require numpy through csbdeep.
The real issue is that we need numpy to even build the wheel (package), i.e. our setup.py imports from numpy.

I've just added a pyproject.toml, which will hopefully fix this issue in the next release.

Best,
Uwe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants