This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Popup): add inline prop #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
miroslavstastny
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1017 +/- ##
==========================================
+ Coverage 81.51% 81.52% +<.01%
==========================================
Files 675 675
Lines 8755 8756 +1
Branches 1492 1492
==========================================
+ Hits 7137 7138 +1
Misses 1602 1602
Partials 16 16
Continue to review full report at Codecov.
|
Updated test for the inline prop
updated changelog with PR link
-added example
miroslavstastny
approved these changes
Mar 6, 2019
layershifter
reviewed
Mar 6, 2019
docs/src/examples/components/Popup/Types/PopupExampleInline.shorthand.tsx
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Mar 6, 2019
layershifter
approved these changes
Mar 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added inline prop for rendering the content of the Popup, next to the trigger element.