This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Popup): Do not propagate keyboard event only when focus trap behavior is used #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophieH29
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
added 2 commits
March 7, 2019 13:03
layershifter
reviewed
Mar 7, 2019
layershifter
reviewed
Mar 7, 2019
mnajdova
reviewed
Mar 7, 2019
mnajdova
approved these changes
Mar 7, 2019
layershifter
approved these changes
Mar 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #1028 +/- ##
==========================================
+ Coverage 81.52% 81.64% +0.12%
==========================================
Files 675 675
Lines 8756 8756
Branches 1492 1492
==========================================
+ Hits 7138 7149 +11
+ Misses 1602 1592 -10
+ Partials 16 15 -1
Continue to review full report at Codecov.
|
sophieH29
deleted the
fix/popup-do-not-propagate-event-when-focus-trap-only
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.