This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Segment): base implementation #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzhelov
requested review from
dvdzkwsk,
levithomason and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 88.13% 88.39% +0.25%
==========================================
Files 43 45 +2
Lines 725 741 +16
Branches 96 106 +10
==========================================
+ Hits 639 655 +16
Misses 83 83
Partials 3 3
Continue to review full report at Codecov.
|
src/components/Segment/Segment.tsx
Outdated
| import * as PropTypes from 'prop-types' | ||
| import { customPropTypes, UIComponent, childrenExist } from '../../lib' | ||
|
|
||
| export type IconXSpacing = 'none' | 'before' | 'after' | 'both' |
There was a problem hiding this comment.
What is the IconXSpacing here good for?
There was a problem hiding this comment.
thanks - it should be removed from here!
miroslavstastny
approved these changes
Aug 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Segment
Used to create grouping of related content.
TODO
API Proposal (default)
content
Is used in shorthand version of Segment.
Children API
Renders children if provided.