Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(tests): reactivate tests for Text #104

Merged
merged 3 commits into from
Aug 20, 2018
Merged

Conversation

kuzhelov
Copy link
Contributor

Reactivate tests for Text - those were ignored due to test file name not matching regexp of Jest.

@codecov
Copy link

codecov bot commented Aug 17, 2018

Codecov Report

Merging #104 into master will increase coverage by 0.46%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   86.05%   86.52%   +0.46%     
==========================================
  Files          39       39              
  Lines         667      668       +1     
  Branches      102       93       -9     
==========================================
+ Hits          574      578       +4     
+ Misses         90       87       -3     
  Partials        3        3
Impacted Files Coverage Δ
src/components/Text/Text.tsx 100% <100%> (+21.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0617b74...688b7bc. Read the comment docs.

@kuzhelov kuzhelov changed the title fix(tests): return tests for Text fix(tests): reactivate tests for Text Aug 17, 2018
Copy link
Contributor

@alinais alinais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mandatory. @levithomason please approve.

@kuzhelov kuzhelov merged commit 00375ed into master Aug 20, 2018
@levithomason
Copy link
Member

levithomason commented Aug 20, 2018

Heads up, do not include changelog entries for chores. The entries and messaging of the entry should be suited for consumers. Enabling or disabling tests does not affect the end user. If there were fixes to the Text component, describe the public facing fixes they can expect.

We want to keep the CHANGELOG very quick to read and pointed on exactly the consumer's experience only.

Finally, please delete your unused branches :)

@levithomason levithomason deleted the fix/tests-for-text-component branch August 20, 2018 22:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants