This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(types): make *Props interface extendable #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
commented
Mar 11, 2019
| @@ -18,6 +18,8 @@ export interface AnimatedComponentProps { | |||
| export interface UIComponentProps<P = any, V = any> | |||
| extends StyledComponentProps<P, V>, | |||
| AnimatedComponentProps { | |||
| [key: string]: any | |||
There was a problem hiding this comment.
All of our components (except, Flex) that actually should have extendable props are using this interface
Codecov Report
@@ Coverage Diff @@
## master #1042 +/- ##
=======================================
Coverage 81.77% 81.77%
=======================================
Files 687 687
Lines 8822 8822
Branches 1498 1498
=======================================
Hits 7214 7214
Misses 1593 1593
Partials 15 15
Continue to review full report at Codecov.
|
…com/stardust-ui/react into fix/types-extendable # Conflicts: # package.json # packages/react/src/components/Ref/Ref.tsx # yarn.lock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1026.