-
Notifications
You must be signed in to change notification settings - Fork 55
fix(Menu): Add aria posinset and setsize, hide indicator from narration #1066
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1066 +/- ##
==========================================
+ Coverage 81.89% 81.91% +0.01%
==========================================
Files 693 693
Lines 8447 8450 +3
Branches 1233 1233
==========================================
+ Hits 6918 6922 +4
+ Misses 1514 1513 -1
Partials 15 15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for code changes
@kolaps33 could you please review/verify accessibility?
itemPosition?: number | ||
|
||
/** MenuItem count inside Menu. */ | ||
itemsCount?: number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These props will be added to public API actually, I'm fine with this for now, but I'm not sure that components should be so coupled with accessibility concerns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I am aware. but as far as I know, we do not have any other option to pass the information from parent menu to the menu item behaviors.
Tested with following: narrating position correctly :) OSX/Chrome/VoiceOver still exists the issue: |
This fixes menu items narration especially for older versions of Chromium.
Might also fix #982 (but verification is needed)