This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(renderer): disable devMode
for Fela by default
#1090
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1088.
When Fela's renderer is in
devMode
(default before), theinsertRule()
function uses a de-optimized code path (insertRuleInDevMode.js
) for writing style updates to the style nodes. It replaces the text of the style node in the head, opposed to using the browser's optimizedCSSStyleSheet.insertRule()
method.It's friendly for development tools because you can edit styles, but it provides wrong development experience for consumers because components are much slower.
devMode=true
devMode=false