Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(List): update styles for Teams Dark and HC themes #1117

Merged
merged 3 commits into from
Mar 28, 2019

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Mar 27, 2019

Fixes #1056.

Dark theme

Before

image

After

image

HC theme

Before

image

After

image

Copy link
Collaborator

@bmdalex bmdalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #1117 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
+ Coverage   82.02%   82.03%   +<.01%     
==========================================
  Files         720      722       +2     
  Lines        8605     8609       +4     
  Branches     1234     1234              
==========================================
+ Hits         7058     7062       +4     
  Misses       1530     1530              
  Partials       17       17
Impacted Files Coverage Δ
.../themes/teams/components/List/listItemVariables.ts 66.66% <ø> (ø) ⬆️
...es/teams-dark/components/List/listItemVariables.ts 100% <100%> (ø)
.../react/src/themes/teams-dark/componentVariables.ts 100% <100%> (ø) ⬆️
...c/themes/teams-high-contrast/componentVariables.ts 100% <100%> (ø) ⬆️
...high-contrast/components/List/listItemVariables.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0dfe57...f4847bf. Read the comment docs.

@layershifter layershifter merged commit ec02c72 into master Mar 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/list-color-dark branch March 28, 2019 11:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 fix Introduces fix for broken behavior. 🚀 ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants