Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(chore): remove static type references for slotClassNames #1145

Merged
merged 3 commits into from
Apr 1, 2019

Conversation

kuzhelov
Copy link
Contributor

@kuzhelov kuzhelov commented Apr 1, 2019

TODO

  • introduce changelog entry

This PR temporarily removes static type references from slotClassNames, as it serves as a source of circular dependencies problem. This move doesn't introduce breaking changes to the client and, at the same time, provides us with some time to

  • introduce necessary checks to detect malicious circular dependencies
  • come up with better approach to handle potential duplications in slotClassNames strings (although, most of them have reasons to exist).

This fix also removes circular dependency between Menu -> MenuItem -> Menu that currently fails docs from start.

@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #1145 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1145   +/-   ##
=======================================
  Coverage   82.33%   82.33%           
=======================================
  Files         730      730           
  Lines        8684     8684           
  Branches     1167     1232   +65     
=======================================
  Hits         7150     7150           
  Misses       1519     1519           
  Partials       15       15
Impacted Files Coverage Δ
packages/react/src/components/Header/Header.tsx 100% <ø> (ø) ⬆️
...ges/react/src/components/RadioGroup/RadioGroup.tsx 95.23% <ø> (ø) ⬆️
packages/react/src/components/Tree/TreeItem.tsx 60.6% <ø> (ø) ⬆️
packages/react/src/components/Chat/Chat.tsx 92.3% <ø> (ø) ⬆️
packages/react/src/components/Menu/Menu.tsx 90.9% <ø> (ø) ⬆️
packages/react/src/components/Form/Form.tsx 100% <ø> (ø) ⬆️
...kages/react/src/components/Accordion/Accordion.tsx 66% <ø> (ø) ⬆️
packages/react/src/components/Tree/Tree.tsx 75.55% <ø> (ø) ⬆️
packages/react/src/components/List/List.tsx 71.62% <ø> (ø) ⬆️
packages/react/src/components/Popup/Popup.tsx 76.34% <ø> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbfc3c7...0aef9bd. Read the comment docs.

@kuzhelov kuzhelov changed the title fix(chore): remove static MenuItem references for Menu fix(chore): remove static type references for slotClassNames Apr 1, 2019
@kuzhelov kuzhelov changed the title fix(chore): remove static type references for slotClassNames fix(chore): remove static type references for slotClassNames Apr 1, 2019
@kuzhelov kuzhelov merged commit 4ae442a into master Apr 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/break-circular-dependencies branch April 1, 2019 13:31
@kuzhelov kuzhelov added the 🧰 fix Introduces fix for broken behavior. label Apr 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 fix Introduces fix for broken behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants