Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(what-input): add functionality for changing the currentInput #1151

Merged
merged 6 commits into from
Apr 2, 2019

Conversation

mnajdova
Copy link
Contributor

@mnajdova mnajdova commented Apr 2, 2019

This PRs adds reset functinality for the what input service, and is used in the Popup. It fixes existing bug in the Popup using the popupFocusTrapBehavior together with the on='hover' prop.

Previously:
popup-bug-prev

After:
popup-bug-after

@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #1151 into master will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1151      +/-   ##
==========================================
- Coverage    82.4%   82.38%   -0.02%     
==========================================
  Files         733      733              
  Lines        8717     8720       +3     
  Branches     1230     1230              
==========================================
+ Hits         7183     7184       +1     
- Misses       1519     1521       +2     
  Partials       15       15
Impacted Files Coverage Δ
packages/react/src/components/Popup/Popup.tsx 75.93% <0%> (-0.41%) ⬇️
packages/react/src/lib/whatInput.ts 63.01% <50%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 750a3b3...1226cda. Read the comment docs.

@mnajdova mnajdova changed the title feat(what-input): add reset functionality feat(what-input): add functionality for changing the currentInput Apr 2, 2019
@mnajdova mnajdova merged commit 130eba1 into master Apr 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/what-input-reset branch April 2, 2019 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants