Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(dropdown): truncate the header and content #1161

Merged
merged 4 commits into from
Apr 5, 2019

Conversation

silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented Apr 3, 2019

Truncates the text content and header for DropdownItem by supplying appropriate props to ListItem.

@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #1161 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1161   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         733      733           
  Lines        8720     8720           
  Branches     1165     1230   +65     
=======================================
  Hits         7184     7184           
  Misses       1521     1521           
  Partials       15       15
Impacted Files Coverage Δ
...ges/react/src/components/Dropdown/DropdownItem.tsx 96% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ea64f1...1301257. Read the comment docs.

Copy link
Contributor

@kuzhelov kuzhelov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, don't forget about changelog entry

@silviuaavram silviuaavram force-pushed the fix-dropdownitem-truncate-text branch from d25342c to 33584d5 Compare April 4, 2019 11:00
@silviuaavram silviuaavram merged commit d814ed0 into master Apr 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-dropdownitem-truncate-text branch April 5, 2019 07:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants