This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(MenuItem): click triggering logic on Space and Enter key press #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzhelov
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1175 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 733 733
Lines 8720 8720
Branches 1230 1231 +1
=======================================
Hits 7184 7184
Misses 1521 1521
Partials 15 15
Continue to review full report at Codecov.
|
sophieH29
reviewed
Apr 5, 2019
| @@ -285,7 +285,7 @@ class MenuItem extends AutoControlledComponent<ReactProps<MenuItemProps>, MenuIt | |||
| } | |||
|
|
|||
| protected actionHandlers: AccessibilityActionHandlers = { | |||
| performClick: event => this.handleClick(event), | |||
| performClick: event => !event.defaultPrevented && this.handleClick(event), | |||
sophieH29
approved these changes
Apr 5, 2019
delete-merged-branch
bot
deleted the
fix/click-on-menu-item-as-popup-trigger
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1155 .
This PR introduces fix for accessibility logic that is aimed to trigger
clickevent handler onSpaceandEnterkey events.The problem was that
clickwas triggered unconditionally while, to match browser's behavior, it should be triggered only in case if event is not default-prevented bye.preventDefault().