This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Icon): export play and pause icons in Teams theme
#1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1189 +/- ##
==========================================
+ Coverage 82.44% 82.46% +0.02%
==========================================
Files 738 740 +2
Lines 8743 8753 +10
Branches 1171 1237 +66
==========================================
+ Hits 7208 7218 +10
Misses 1519 1519
Partials 16 16
Continue to review full report at Codecov.
|
kuzhelov
reviewed
Apr 8, 2019
CHANGELOG.md
Outdated
| @@ -27,6 +27,9 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
| - Fix `rotate` prop on `Icon` not working in `rtl` @mnajdova ([#1179](https://github.com/stardust-ui/react/pull/1179)) | |||
| - `FocusTrapZone` - Do not propagate any keyboard events @sophieH29 ([#1180](https://github.com/stardust-ui/react/pull/1180)) | |||
|
|
|||
| ### Features | |||
| - Export `flag` icon in Teams theme @layershifter ([#1189](https://github.com/stardust-ui/react/pull/1189)) | |||
There was a problem hiding this comment.
a bit lost here - seems that PR description doesn't correspond to the actual changes introduced. Also, it seems that there is a mistaken item referenced in the PR description as 'fixed' - or it was about something specific from this referenced PR?
There was a problem hiding this comment.
Thanks, copy paste is evil sometimes, updated 👍
codepretty
approved these changes
Apr 8, 2019
…at/export-play-pause-icons
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1187.
This PR add new
playandpauseicons, FontAwesome uses exactly these names.