This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(MenuItem): prop types #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzhelov
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1197 +/- ##
=======================================
Coverage 82.48% 82.48%
=======================================
Files 742 742
Lines 8758 8758
Branches 1236 1236
=======================================
Hits 7224 7224
Misses 1519 1519
Partials 15 15
Continue to review full report at Codecov.
|
| @@ -105,7 +105,7 @@ export interface MenuItemProps | |||
| wrapper?: ShorthandValue | |||
|
|
|||
| /** Shorthand for the submenu. */ | |||
| menu?: ShorthandValue | |||
| menu?: ShorthandValue | ShorthandValue[] | |||
There was a problem hiding this comment.
Suggested change
| menu?: ShorthandValue | ShorthandValue[] | |
| menu?: ShorthandValue | ShorthandCollection |
| menu: customPropTypes.itemShorthand, | ||
| menu: PropTypes.oneOfType([ | ||
| customPropTypes.itemShorthand, | ||
| PropTypes.arrayOf(customPropTypes.itemShorthand), |
There was a problem hiding this comment.
Suggested change
| PropTypes.arrayOf(customPropTypes.itemShorthand), | |
| customPropTypes.collectionShorthand, |
layershifter
suggested changes
Apr 10, 2019
layershifter
added
the
needs author changes
…t-ui/react into fix/menu-item-prop-types
layershifter
approved these changes
Apr 10, 2019
kuzhelov
added
🚀 ready for review
and removed
needs author changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1112