Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Adding keyboard enter and spacebar functionality for the Tree component #1233

Merged
merged 9 commits into from
Apr 17, 2019

Conversation

priyankar205
Copy link
Collaborator

  1. Added open & close subtree functionality (for accessibility) from keyboard.

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #1233 into master will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1233      +/-   ##
==========================================
- Coverage   83.21%   83.19%   -0.03%     
==========================================
  Files         754      754              
  Lines        8913     8918       +5     
  Branches     1194     1194              
==========================================
+ Hits         7417     7419       +2     
- Misses       1482     1485       +3     
  Partials       14       14
Impacted Files Coverage Δ
packages/react/src/components/Tree/TreeItem.tsx 62.5% <ø> (+1.89%) ⬆️
packages/react/src/components/Tree/TreeTitle.tsx 60.86% <0%> (-12.82%) ⬇️
.../accessibility/Behaviors/Tree/treeTitleBehavior.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c85059...b4346ea. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #1233 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1233      +/-   ##
==========================================
- Coverage   83.21%   83.19%   -0.02%     
==========================================
  Files         754      754              
  Lines        8912     8916       +4     
  Branches     1262     1194      -68     
==========================================
+ Hits         7416     7418       +2     
- Misses       1482     1484       +2     
  Partials       14       14
Impacted Files Coverage Δ
packages/react/src/components/Tree/TreeTitle.tsx 66.66% <0%> (-7.02%) ⬇️
.../accessibility/Behaviors/Tree/treeTitleBehavior.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe9cbf3...be7011c. Read the comment docs.

@priyankar205 priyankar205 merged commit cb22c66 into master Apr 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the priyankar/tree-keyboard-accessibility branch April 17, 2019 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants