This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(dropdown): cleanup add and remove a11y messages #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviuaavram
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1237 +/- ##
==========================================
+ Coverage 71.57% 71.91% +0.34%
==========================================
Files 731 731
Lines 5583 5591 +8
Branches 1634 1612 -22
==========================================
+ Hits 3996 4021 +25
+ Misses 1582 1565 -17
Partials 5 5
Continue to review full report at Codecov.
|
silviuaavram
force-pushed
the
fix-cleanup-add-remove-a11y-message
branch
from
231f4fb
to
598ebb7
Compare
silviuaavram
force-pushed
the
fix-cleanup-add-remove-a11y-message
branch
from
598ebb7
to
80e6e16
Compare
layershifter
approved these changes
Apr 24, 2019
delete-merged-branch
bot
deleted the
fix-cleanup-add-remove-a11y-message
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear the text added in the aria live container, so that virtual cursor will not read it afterwards.
Works only for the text that is added on add and on remove, in multiple selection cases. Should fix our issue for now. The other status text is generated by Downshift, will need to fix it as well in the future.