This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Input): move styles to Base theme #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1247 +/- ##
==========================================
- Coverage 71.58% 71.57% -0.02%
==========================================
Files 730 731 +1
Lines 5582 5583 +1
Branches 1612 1634 +22
==========================================
Hits 3996 3996
- Misses 1581 1582 +1
Partials 5 5
Continue to review full report at Codecov.
|
…ub.com/stardust-ui/react into chore/move-input-styles
mnajdova
reviewed
Apr 23, 2019
|
|
||
| inputPadding: `${pxToRem(7)} ${pxToRem(12)}`, | ||
| inputFocusBorderBottomColor: siteVars.colors.primary[500], | ||
| inputFocusBorderColor: `transparent transparent ${siteVars.colors.primary[500]} transparent`, |
There was a problem hiding this comment.
I hate that we are using input as part of the variables name, but the input is a shorthand of the Input component, so I don't see any better way... :(
There was a problem hiding this comment.
I don't have better ideas there, too :(
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
Inputstyles to Base theme.BREAKING CHANGES
In
InputVariablestheinputFocusBorderBottomColorvariables was renamed toinputFocusBorderColor. It allows to customize all borders instead of onlybottom.Before
After