This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Dropdown): added onClick override on DropdownItem #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviuaavram
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1248 +/- ##
=========================================
+ Coverage 71.91% 72.1% +0.18%
=========================================
Files 731 731
Lines 5591 5592 +1
Branches 1612 1612
=========================================
+ Hits 4021 4032 +11
+ Misses 1565 1555 -10
Partials 5 5
Continue to review full report at Codecov.
|
|
Can you please add a UT for this? |
packages/react/test/specs/components/Dropdown/Dropdown-test.tsx
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Apr 23, 2019
|
And please mention in PR description and changelog that we stopped propagate events. |
Co-Authored-By: silviuavram <silviu.avram91@gmail.com>
…st-ui/react into fix-override-dropdownitem
jurokapsiar
approved these changes
Apr 23, 2019
…st-ui/react into fix-override-dropdownitem
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows supplying an override to onClick for a
DropdownItem.For now I am not sure if we want a default stopPropagation from our code, open to debate.