This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Dropdown): keep focused style when focus is on List #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviuaavram
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1258 +/- ##
==========================================
+ Coverage 72.1% 72.14% +0.03%
==========================================
Files 731 731
Lines 5592 5596 +4
Branches 1612 1636 +24
==========================================
+ Hits 4032 4037 +5
+ Misses 1555 1554 -1
Partials 5 5
Continue to review full report at Codecov.
|
silviuaavram
force-pushed
the
fix-focus-style-dropdown
branch
from
e4401b9
to
c2d3dc0
Compare
jurokapsiar
approved these changes
Apr 24, 2019
silviuaavram
force-pushed
the
fix-focus-style-dropdown
branch
from
854462c
to
16f5384
Compare
silviuaavram
added
accessibility
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Single and Multiple selections, when Dropdown was open, focus was moved to the List. After that, the underlined focused style was removed.
This PR aims to fix it.