Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(dialogs): themeing support for Teams dark and hc #1297

Merged
merged 14 commits into from
May 17, 2019

Conversation

codepretty
Copy link
Collaborator

@codepretty codepretty commented May 7, 2019

Fixes #1313.

This does not include all the redline work for Dialogs. This is just to fix the Dialog's color support in Teams dark and Teams high contrast themes.

Screenshots below (Before | After)
Teams theme
image

Teams dark theme
image

Teams high contrast theme
image

@codepretty codepretty changed the title fix(dialogs): basic themeing support for Teams dark and hc fix(dialogs): themeing support for Teams dark and hc May 7, 2019
@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #1297 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1297      +/-   ##
=========================================
- Coverage    72.3%   72.2%   -0.11%     
=========================================
  Files         764     769       +5     
  Lines        5769    5777       +8     
  Branches     1688    1712      +24     
=========================================
  Hits         4171    4171              
- Misses       1592    1600       +8     
  Partials        6       6
Impacted Files Coverage Δ
...src/themes/teams/components/Dialog/dialogStyles.ts 0% <0%> (ø)
...high-contrast/components/Dialog/dialogVariables.ts 0% <0%> (ø)
...es/teams-dark/components/Dialog/dialogVariables.ts 0% <0%> (ø)
.../themes/teams/components/Dialog/dialogVariables.ts 0% <0%> (ø)
...ms-high-contrast/components/Dialog/dialogStyles.ts 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58353a0...e84efed. Read the comment docs.

Copy link
Member

@miroslavstastny miroslavstastny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment added, other than that 👍

@codepretty codepretty merged commit f0635e4 into master May 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/dialog-themeing branch May 17, 2019 22:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dialog Component breaks in Dark mode
4 participants