Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(icon): export qna and yammer icons #1325

Merged
merged 9 commits into from
May 17, 2019

Conversation

lawrencecushman
Copy link
Contributor

@lawrencecushman lawrencecushman commented May 10, 2019

exports qna and yammer icons to the Teams theme

image
image

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #1325 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
+ Coverage   72.29%   72.37%   +0.08%     
==========================================
  Files         762      760       -2     
  Lines        5767     5686      -81     
  Branches     1712     1687      -25     
==========================================
- Hits         4169     4115      -54     
+ Misses       1592     1565      -27     
  Partials        6        6
Impacted Files Coverage Δ
...omponents/Icon/svg/ProcessedIcons/icons-yammer.tsx 100% <ø> (ø) ⬆️
...s/components/Icon/svg/ProcessedIcons/icons-qna.tsx 100% <ø> (ø) ⬆️
.../themes/teams/components/Icon/svg/icons/yammer.tsx 100% <100%> (ø)
...src/themes/teams/components/Icon/svg/icons/qna.tsx 100% <100%> (ø)
...ackages/react/src/components/Dropdown/Dropdown.tsx 87.75% <0%> (-0.77%) ⬇️
...ckages/react/src/components/Button/ButtonGroup.tsx 94.11% <0%> (ø) ⬆️
...kages/react/src/themes/teams-dark/siteVariables.ts 100% <0%> (ø) ⬆️
packages/react/src/components/Button/Button.tsx 90.9% <0%> (ø) ⬆️
...es/react/src/components/Reaction/ReactionGroup.tsx 100% <0%> (ø) ⬆️
...ckages/react/src/components/Portal/PortalInner.tsx 100% <0%> (ø) ⬆️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f4f93...70b78c0. Read the comment docs.

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #1325 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
+ Coverage   72.36%   72.37%   +<.01%     
==========================================
  Files         758      760       +2     
  Lines        5684     5686       +2     
  Branches     1663     1687      +24     
==========================================
+ Hits         4113     4115       +2     
  Misses       1565     1565              
  Partials        6        6
Impacted Files Coverage Δ
...omponents/Icon/svg/ProcessedIcons/icons-yammer.tsx 100% <ø> (ø) ⬆️
...s/components/Icon/svg/ProcessedIcons/icons-qna.tsx 100% <ø> (ø) ⬆️
.../themes/teams/components/Icon/svg/icons/yammer.tsx 100% <100%> (ø)
...src/themes/teams/components/Icon/svg/icons/qna.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9ec02c...655debf. Read the comment docs.

@miroslavstastny
Copy link
Member

Please review and approve the screener changes before merging.

@lawrencecushman
Copy link
Contributor Author

@miroslavstastny is this ready to go in? Can we merge today?

@alinais alinais merged commit 7c68bdf into microsoft:master May 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants