This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Ref): handle refs on updates of innerRef prop
#1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1331 +/- ##
==========================================
+ Coverage 72.32% 72.33% +<.01%
==========================================
Files 759 759
Lines 5692 5694 +2
Branches 1687 1664 -23
==========================================
+ Hits 4117 4119 +2
Misses 1569 1569
Partials 6 6
Continue to review full report at Codecov.
|
kuzhelov
reviewed
May 13, 2019
| @@ -32,13 +32,17 @@ export default class RefFindNode extends React.Component<RefFindNodeProps> { | |||
| handleRef(this.props.innerRef, this.prevNode) | |||
| } | |||
|
|
|||
| componentDidUpdate() { | |||
| componentDidUpdate(prevProps: RefFindNodeProps) { | |||
There was a problem hiding this comment.
think that it might be beneficial to implement this component with Hooks, for couple of reasons
- in that case we will have explicit update dependencies specified in
useEffect - explicitness on
unsubscribeactions for effects - this component is fairly small in terms of amount of code
kuzhelov
approved these changes
May 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1328.
Align existing behavior with React's, see the issue for more context and explanation.