Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(menu): automatic positioning inside viewport #1384

Merged
merged 9 commits into from
May 28, 2019

Conversation

bmdalex
Copy link
Collaborator

@bmdalex bmdalex commented May 23, 2019

feat(menu): automatic positioning inside viewport

Fixes #1360

Description

Open Menus and submenus at lower part of screen
image

Expected Result

menus and submenus are automatically rendered inside viewport (on top)

Actual Result

menus and submenus are cut off when there is not enough space in the viewport 馃挘

DEMO with current behavior

Screen Recording 2019-05-23 at 19 13 31

@bmdalex bmdalex added 鈿欙笍 enhancement New feature or request 馃殌 ready for review 馃О fix Introduces fix for broken behavior. labels May 23, 2019
@bmdalex bmdalex self-assigned this May 23, 2019
@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #1384 into master will increase coverage by 0.06%.
The diff coverage is 80.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1384      +/-   ##
==========================================
+ Coverage   73.51%   73.57%   +0.06%     
==========================================
  Files         786      787       +1     
  Lines        5863     5885      +22     
  Branches     1703     1734      +31     
==========================================
+ Hits         4310     4330      +20     
- Misses       1547     1549       +2     
  Partials        6        6
Impacted Files Coverage 螖
packages/react/src/components/Menu/MenuItem.tsx 30.85% <0%> (-0.68%) 猬囷笍
...src/themes/teams/components/Menu/menuItemStyles.ts 7.2% <0%> (+0.11%) 猬嗭笍
packages/react/src/lib/positioner/Popper.tsx 78.78% <100%> (+2.12%) 猬嗭笍
...ckages/react/src/lib/positioner/getScrollParent.ts 89.47% <89.47%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update f09083d...97b07ae. Read the comment docs.

@bmdalex bmdalex force-pushed the feat/menu-positioning branch 7 times, most recently from a880b2c to ee0cabc Compare May 27, 2019 20:57
@bmdalex bmdalex merged commit c69313c into master May 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/menu-positioning branch May 28, 2019 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
鈿欙笍 enhancement New feature or request 馃О fix Introduces fix for broken behavior. 馃殌 ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menus with submenus are cut-off
5 participants