This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(attachment): action click #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1444 +/- ##
======================================
Coverage 73.6% 73.6%
======================================
Files 787 787
Lines 5907 5907
Branches 1744 1744
======================================
Hits 4348 4348
Misses 1553 1553
Partials 6 6
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1444 +/- ##
=======================================
Coverage 73.14% 73.14%
=======================================
Files 805 805
Lines 6073 6073
Branches 1775 1794 +19
=======================================
Hits 4442 4442
Misses 1625 1625
Partials 6 6
Continue to review full report at Codecov.
|
layershifter
approved these changes
Jun 3, 2019
bmdalex
force-pushed
the
fix/attachment-action-click
branch
from
03386c7
to
c95241d
Compare
jurokapsiar
reviewed
Jun 4, 2019
| @@ -22,6 +22,7 @@ const getPseudoElementStyles = (args: BorderPseudoElementStyles): ICSSInJSStyle | |||
| content: '""', | |||
| position: 'absolute', | |||
| borderStyle: 'solid', | |||
| pointerEvents: 'none', | |||
There was a problem hiding this comment.
@kolaps33 please test this with screen readers
bmdalex
force-pushed
the
fix/attachment-action-click
branch
from
c95241d
to
ab6f9ed
Compare
kolaps33
reviewed
Jun 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(attachment): action click
Description
This PR fixes #1334
Steps to reproduce issue:
Fix
Add
pointerEvents: 'none'togetBorderFocusStyles.tsstyle helper in order ignore pointer events for the pseudo elements.BEFORE
The Attachment onClick event is fired when clicking the action icon when the attachment is focused.
AFTER