This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
perf(themes): use minified normalize.css in Teams theme #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1476 +/- ##
=======================================
Coverage 73.14% 73.14%
=======================================
Files 805 805
Lines 6073 6073
Branches 1794 1794
=======================================
Hits 4442 4442
Misses 1625 1625
Partials 6 6
Continue to review full report at Codecov.
|
miroslavstastny
approved these changes
Jun 10, 2019
CHANGELOG.md
Outdated
| @@ -34,6 +34,9 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
| - Fix Teams' theme list item end media styles @mnajdova ([#1448](https://github.com/stardust-ui/react/pull/1448)) | |||
| - Fix the order of the fela plugin @mnajdova ([#1461](https://github.com/stardust-ui/react/pull/1461)) | |||
|
|
|||
| ### Performance | |||
| - Use minified version of `normalize.css` @layershifter ([#1476](https://github.com/stardust-ui/react/pull/1476)) | |||
There was a problem hiding this comment.
You also upgraded normalize from 8.0.0 to 8.0.1. Should it be mentioned in the changelog?
There was a problem hiding this comment.
Updated the entry 👍
….com/stardust-ui/react into chore/normalize-to-js
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1311.
Problem
Currently
normalizeCSSis a string that can't be properly minified by bundlers:Solution
Use minified version.
Props
Impossible solutionConvert
normalizeCSSto an object, however the main problem is a different API in Fela'srenderStatic():I don't think that effort that we will spent there will have much gain for us.