Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(AccessibilityBehaviors): Define types for accessibility behaviors #1481

Merged
merged 9 commits into from
Jun 11, 2019
Merged

feat(AccessibilityBehaviors): Define types for accessibility behaviors #1481

merged 9 commits into from
Jun 11, 2019

Conversation

sophieH29
Copy link
Contributor

@sophieH29 sophieH29 commented Jun 10, 2019 •
edited

Closes #1472

Some improvements:

'aria-disabled': !_.isNil(props['aria-disabled'])
        ? props['aria-disabled']
        : !!props['disabled']	
        ? true	
        : undefined,

was simplified just to this

'aria-disabled': props.disabled,

Since unhandledProps go after accessibility attributes in components and can override it in any case, no need to check if the attribute was passed.

@sophieH29 sophieH29 added ⚙️ enhancement New feature or request 🚀 ready for review accessibility All the Accessibility tasks and bugs should be tagged with this. labels Jun 10, 2019
@sophieH29 sophieH29 self-assigned this Jun 10, 2019
layershifter
layershifter reviewed Jun 10, 2019
View reviewed changes
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Please fix CI and reuse types 👍

Sofiya Huts added 4 commits June 11, 2019 09:35
Merge branch 'master' into feat/acc-behaviors-add-typings-props
97db5c2 
# Conflicts:
#	packages/react/src/lib/accessibility/Behaviors/Checkbox/checkboxBehavior.ts
#	packages/react/src/lib/accessibility/Behaviors/Tree/treeBehavior.ts
small improvement
7344752
Improvements after CR comments
be3003e
fix test
7fa9e92
@layershifter
Copy link
Member

Do not forget about CHANGELOG.md: we definitely should mention changes for aria-disabled

@sophieH29 sophieH29 merged commit 2349665 into master Jun 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/acc-behaviors-add-typings-props branch June 11, 2019 10:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@layershifter layershifter layershifter approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@kuzhelov kuzhelov Awaiting requested review from kuzhelov

@levithomason levithomason Awaiting requested review from levithomason levithomason is a code owner

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny miroslavstastny is a code owner

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees

@sophieH29 sophieH29

Labels
accessibility All the Accessibility tasks and bugs should be tagged with this. ⚙️ enhancement New feature or request 🚀 ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define types for accessibility behavior props
2 participants
@sophieH29 @layershifter