Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(docs): improve color guide #1494

Merged
merged 21 commits into from
Jun 14, 2019
Merged

feat(docs): improve color guide #1494

merged 21 commits into from
Jun 14, 2019

Conversation

mnajdova
Copy link
Contributor

@mnajdova mnajdova commented Jun 13, 2019

This PR introduced improvements on the guides regarding colors. Things implemented:

  • added new page for exploring the color scheme available
  • restructure the color guide, by providing the code sample before the color scheme
  • restricted the color scheme example on the colors guide, to show few colors with fading ending, and added see more button that will navigate to the new page
  • removed copy functionality from the color box

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #1494 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1494   +/-   ##
=======================================
  Coverage   73.43%   73.43%           
=======================================
  Files         822      822           
  Lines        6192     6192           
  Branches     1797     1797           
=======================================
  Hits         4547     4547           
  Misses       1640     1640           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bedc0a1...e415d1d. Read the comment docs.

-added Fader for the color scheme in the color palette
@kuzhelov
Copy link
Contributor

see that 'copy color' functionality is still preserved for tint colors - is it intentional?

image

@mnajdova
Copy link
Contributor Author

@kuzhelov not sure if we want to remove it from everywhere, as for color palette, for designers they may actually want to copy this... On the other hand, if developer is taking a look, they may think it's okay to copy them, so maybe we should actually remove the copy to clipboard functionality from here as well. What do you think?

@kuzhelov
Copy link
Contributor

kuzhelov commented Jun 14, 2019

yes, couple of thoughts on that

  • the copy-paste functionality for Design team should be preserved,
  • at the same time, it is better to refrain from using copy-paste buttons in the developers guide - as this will provide false intuition that colors should be just copy-pasted to styles.

Given all that, ideally I see it as two separate pages:

  • developers guide page, the one we have now: no copy-paste buttons there for colors, but there are links to
  • Teams color palette page, for Design team. There is an introduction text that explicitly says that color values should be copy pasted by devs, this is just designer's tool - and this text is followed by actual Teams color palette.

In that case we will also be able to save additional space on the Devs guide page (as we won't need to reference all color gradients in All colors section, as an example - we will be able just to omit it).

Please, let me know what do you think?

@mnajdova mnajdova merged commit da02bc4 into master Jun 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/improve-colors-guide branch June 14, 2019 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants